Add gRPC big5/vector search test procedures #689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
finnegancarroll
requested review from
IanHoang,
OVI3D0,
VijayanB,
beaioun,
gkamat and
rishabh6788
as code owners
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
gkamat
requested changes
Oct 21, 2025
Collaborator
gkamat
left a comment
gkamat
left a comment
There was a problem hiding this comment.
Can you add an update to the README for the workload regarding this additional functionality?
Also, can you indicate the OpenSearch versions this change should be backported to, in the PR description above? It is probably only the 3 branch, but please confirm.
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
finnegancarroll
changed the title
Contributor
Author
|
Thanks for taking a look @gkamat , added entries in the big5/vector search readme for gRPC usage.
Yes these workloads will be OS 3.x only. |
gkamat
approved these changes
Oct 27, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 27, 2025
(cherry picked from commit 8fa8127) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gkamat
pushed a commit
that referenced
this pull request
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new test procedures for the gRPC/protobuf transport.
--test-procedure="grpc-big5"A test procedure mirroring big5 on the gRPC transport.
As search api support on this transport is limited only grpc-bulk, grpc-match-all, and grpc-term operations included.
--test-procedure="grpc-no-train-test"A vector search test procedure which mimics
no-train-testwith grpc-prod-queries instead of REST api queries.This is a starting point for these workloads and we expect to expand them as gRPC search API support grows.
Issues Resolved
N/A
Testing
- [ ] New functionality includes testingManually tested with OSB
Backport to Branches:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.